Subject: [FFC-dev] [HG FFC] Fix bug for quadrature generation, passing all tests again.

From: [email-masked] (FFC)
Date: Tue, 21 Apr 2009 11:10:28 +0200 (CEST)

One or more new changesets pushed to the primary ffc repository.
A short summary of the last three changesets is included below.

changeset:   1508:9c2cc8b3bde558e9bf3ea8372269f2ddbdf9d6d7
tag:         tip
user:        "Kristian Oelgaard <[email-masked]>"
date:        Tue Apr 21 11:10:12 2009 +0200
files:       ffc/compiler/codegeneration/quadrature/uflquadraturegenerator_utils.py ffc/fem/quadratureelement.py
description:
Fix bug for quadrature generation, passing all tests again.

changeset:   1507:e41d63710440d4fadf6d2499e91a5b6ca1e6c3ac
user:        "Kristian Oelgaard <[email-masked]>"
date:        Tue Apr 21 09:50:36 2009 +0200
files:       ffc/common/constants.py ffc/jit/jit.py ffc/jit/jitobject.py test/unit/test.py
description:
Fix unit test for JIT compiler (more cleanup is needed in jit.py and jitobject.py).

changeset:   1506:fbeeaf084b14549672b1f71a129e958c047a8979
user:        Anders Logg <[email-masked]>
date:        Mon Apr 20 22:44:36 2009 +0200
files:       ffc/__init__.py ffc/compiler/analysis/elementdata.py ffc/compiler/analysis/formdata.py ffc/compiler/codegeneration/common/finiteelement.py ffc/compiler/codegeneration/quadrature/uflquadraturegenerator_utils.py ffc/compiler/codegeneration/tensor/tensorgenerator.py ffc/compiler/compiler.py ffc/compiler/language/README ffc/compiler/language/__init__.py ffc/compiler/language/algebra.py ffc/compiler/language/builtins.py ffc/compiler/language/index.py ffc/compiler/language/indexcall.py ffc/compiler/language/indexreordering.py ffc/compiler/language/integral.py ffc/compiler/language/operators.py ffc/compiler/language/reassignment.py ffc/compiler/language/restriction.py ffc/compiler/language/signature.py ffc/compiler/language/tokens.py ffc/compiler/representation/tensor/facetmap.py ffc/compiler/representation/tensor/factorization.py ffc/compiler/representation/tensor/geometrytensor.py ffc/compiler/representation/tensor/monomialextraction.py ffc/compiler/representation/tensor/monomialintegration.py ffc/compiler/representation/tensor/referencetensor.py ffc/compiler/representation/tensor/tensorreordering.py ffc/compiler/representation/tensor/tensorrepresentation.py ffc/compiler/representation/tensor/ufltensorrepresentation.py ffc/compiler/uflcompiler.py ffc/fem/finiteelement.py ffc/fem/mixedelement.py ffc/jit/jit.py ffc/jit/jitobject.py scripts/ffc test/unit/test.py
description:
Delete a lot of old stuff.

----------------------------------------------------------------------
For more details, visit http://www.fenics.org/hg/ffc

---

From: Anders Logg <[email-masked]>
Date: Tue, 21 Apr 2009 11:45:22 +0200

Nice.

I see that you also use extract_unique_elements in
uflquadraturegenerator.py. Is this necessary. The elements are already
extracted in the analysis stage and stored in FormData.

I'd like to remove the analysis module.

-- 
Anders

On Tue, Apr 21, 2009 at 11:10:28AM +0200, FFC wrote:
> _______________________________________________
> FFC-dev mailing list
> [email-masked]
> http://www.fenics.org/mailman/listinfo/ffc-dev

---

From: Kristian Oelgaard <[email-masked]>
Date: Tue, 21 Apr 2009 12:06:04 +0200

> extracted in the analysis stage and stored in FormData.

Yes, I'll try to figure out how to reuse this info.

> I'd like to remove the analysis module.

Go ahead, 'extract_unique_element' is the UFL function, so it should be OK to
remove.

Kristian

> > files:
> ffc/compiler/codegeneration/quadrature/uflquadraturegenerator_utils.py
> ffc/fem/quadratureelement.py
> > description:
> > files:       ffc/__init__.py ffc/compiler/analysis/elementdata.py
> ffc/compiler/analysis/formdata.py
> ffc/compiler/codegeneration/common/finiteelement.py
> ffc/compiler/codegeneration/quadrature/uflquadraturegenerator_utils.py
> ffc/compiler/codegeneration/tensor/tensorgenerator.py
> ffc/compiler/compiler.py ffc/compiler/language/README
> ffc/compiler/language/__init__.py ffc/compiler/language/algebra.py
> ffc/compiler/language/builtins.py ffc/compiler/language/index.py
> ffc/compiler/language/indexcall.py ffc/compiler/language/indexreordering.py
> ffc/compiler/language/integral.py ffc/compiler/language/operators.py
> ffc/compiler/language/reassignment.py ffc/compiler/language/restriction.py
> ffc/compiler/language/signature.py ffc/compiler/language/tokens.py
> ffc/compiler/representation/tensor/facetmap.py
> ffc/compiler/representation/tensor/factorization.py
> ffc/compiler/representation/tensor/geometrytensor.py
> ffc/compiler/representation/tensor/monomialextraction.py
> ffc/compiler/representation/tensor/monomialintegration.py
> ffc/compiler/representation/tensor/referencetensor.py
> ffc/compiler/representation/tensor/tensorreordering.py
> ffc/compiler/representation/tensor/tensorrepresentation.py
> ffc/compiler/representation/tensor/ufltensorrepresentation.py
> ffc/compiler/uflcompiler.py ffc/fem/finiteelement.py ffc/fem/mixedelement.py
> ffc/jit/jit.py ffc/jit/jitobject.py scripts/ffc test/unit/test.py
> > description:

---

From: Anders Logg <[email-masked]>
Date: Tue, 21 Apr 2009 12:11:39 +0200

> Go ahead, 'extract_unique_element' is the UFL function, so it should be OK to

I made a mistake while grepping for use of 'analysis', but the comment
seems to be valid anyway, not using extract_unique_elements even from
UFL at the code generation stage. :-)

-- 
Anders